potatoeggy / mandown

Comic/manga/webtoon downloader and CBZ/EPUB/MOBI/PDF converter
GNU Affero General Public License v3.0
45 stars 7 forks source link

Fix PDF converter stuff #56

Closed austin-zeng closed 1 year ago

austin-zeng commented 1 year ago

Previously, the PDF converter just stitches together all image files in the directory, so for comics where the chapter titles aren't Chapter-001 or similar, the chapters may be joined out of order. For example:

mandown get 'https://mangadex.org/title/34f45c13-2b78-4900-8af2-d0bb551101f4/dorohedoro' --start 1 --end 2 --convert pdf

This PR makes it so chapters are joined in the order specified in the metadata, which is consistent with the epub converter (although like with the epub converter, covers are no longer included... not sure what you want to do about this).

Also, this PR fixes a bug where the pdf converter doesn't work for chapters with very few pages, ex.

mandown get 'https://mangadex.org/title/f9c33607-9180-4ba6-b85c-e4b5faee7192/official-test-manga' --start 1 --end 1 --convert pdf
potatoeggy commented 1 year ago

Nice, thanks!