potatoeggy / mandown

Comic/manga/webtoon downloader and CBZ/EPUB/MOBI/PDF converter
GNU Affero General Public License v3.0
45 stars 7 forks source link

Impossible to download from webtoon #60

Closed stanthewizzard closed 1 year ago

stanthewizzard commented 1 year ago

[1] 59059 zsh: no matches found: https://www.webtoons.com/en/challenge/test/1-1/viewer?title_no=XXXXXX&episode_no=YYYY

[1] + exit 1 mandown get

thanks for help

potatoeggy commented 1 year ago

Try adding quotes around the url?

stanthewizzard commented 1 year ago

Thanks In this case I have this error message

Traceback (most recent call last):

File "/Library/Frameworks/Python.framework/Versions/3.10/bin/mandown", line 8, in sys.exit(main())

File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/mandown/cli.py", line 524, in main app()

File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/mandown/cli.py", line 385, in get comic = cli_query(url)

File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/mandown/cli.py", line 146, in cli_query comic = api.query(url)

File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/mandown/api.py", line 33, in query return BaseComic(adapter.metadata, adapter.chapters)

File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/mandown/sources/base_source.py", line 27, in metadata self._metadata = self.fetch_metadata()

File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/mandown/sources/source_webtoons.py", line 45, in fetch_metadata art_start_idx = cover_art_el["style"].find("url(") + len("url(")

TypeError: 'NoneType' object is not subscriptable

potatoeggy commented 1 year ago

Thanks for the update! https://www.webtoons.com/en/challenge/test/1-1/viewer?title_no=XXXXXX&episode_no=YYYY doesn't seem like a valid Webtoons.com URL. Is there a specific link you're using that's breaking?

stanthewizzard commented 1 year ago

It's the url I'm getting from webtoon

For ex this one https://www.webtoons.com/en/thriller/grasp/episode-1/viewer?title_no=2854&episode_no=1

And this one is working. I don't understand why the one I'm trying to get is not working

magicalsoup commented 1 year ago

Which is the url you're trying to get working?

It you are referring to https://www.webtoons.com/en/challenge/test/1-1/viewer?title_no=XXXXXX&episode_no=YYYY, it is not a valid webtoon url so the service will not work.

potatoeggy commented 1 year ago

@stanthewizzard

https://www.webtoons.com/en/thriller/grasp/episode-1/viewer?title_no=2854&episode_no=1

I can't reproduce the error with this link. Do you have another one that breaks mandown?

EDIT: can reproduce! Any Canvas webtoon breaks. I'll get back to you when I fix it.

stanthewizzard commented 1 year ago

awesome thanks

potatoeggy commented 1 year ago

v1.3.3 should have a fix for this issue - give it a shot?

stanthewizzard commented 1 year ago

Guess what ? IT WORKS like a charm (but I don't know where it's stored on my mac)

stanthewizzard commented 1 year ago

found it really awesome KOMGA time then

potatoeggy commented 1 year ago

:tada: