search

potatoeggy / mandown

Comic/manga/webtoon downloader and CBZ/EPUB/MOBI/PDF converter
GNU Affero General Public License v3.0
45 stars 7 forks source link

Illegal characters for file and folder names (/ and :) in metadata titles #77

Closed ZetsApocNow closed 1 month ago

ZetsApocNow commented 1 month ago

What broke?

Mandown version Output of mandown --version: 1.70

Describe the bug A clear and concise description of what the bug is.

The script isn't removing illegal characters such as : and / from metadata titles, therefore creating invalid file and folder names which then makes the whole thing error out.

Steps to reproduce If the downloader broke, please include a URL that breaks it.

Downloading any comic with : or / in the name, for example

https://readcomiconline.li/Comic/Venom-Sign-of-the-Boss or https://readcomiconline.li/Comic/Venom-Deadpool-What-If

Additional context Add any other context about the problem here.

potatoeggy commented 1 month ago

Thank you for reporting this issue! Please try Mandown 1.8.1, which contains a fix for this bug.

ZetsApocNow commented 1 month ago

The update you did, now makes this happen

AttributeError: 'Metadata' object has no attribute 'title_slug'

Test Url - https://readcomiconline.li/Comic/Venom-Modern-Era-Epic-Collection

potatoeggy commented 1 month ago

Oops — that's what I get for not exhaustively testing. Thanks for catching that! I've run through the full flows with your comic links and they should now all work with v1.8.2.