Open potatoesnmolasses opened 6 months ago
Hi @potatoesnmolasses! Great job hitting checkpoint 2 from the DAO/Hibernate standpoint! Completing the weekly work within your indie project has really set you up well!
[ ] Can you add an image of your ERD so that I can review and provide any feedback (if this is here already and I overlooked it, please let me know). If you don't have a preferred way to create the erd, you can generate it out of the database view in IntelliJ. I think the sequence is right click on the db, then diagrams. I realize I should have been more clear about including this for this CP.
[ ] It's great to see that you starting to use Lombok - how slim your entities will be once it's fully implemented (boilerplate methods removed)!
[ ] I am guessing the generic dao is on your list, but wanted to mentioned it here just in case. It's a nice way to get rid of the duplication across daos. Note that your entity-specific tests will remain, they will just use the generic dao instead.
[ ] You've been doing a good job updating your time log and project plan as you complete work. Related to the plan, if you haven't reviewed and updated your plan recently for the final 8 weeks, this would be a good time to do that, since you now have all the learning on new topics needed for the project (or will have in the next few days).
[ ] I think I mentioned this in the peer code review issue, but wanted to highlight it here as well since log4j/noprintlns is part of cp 2: https://github.com/search?q=repo%3Apotatoesnmolasses%2FNudgeWriting%20print&type=code
I did a little poking around, mostly to look for best practices, and nothing additional jumped out at me as "missed" at this point. Good work there!
I'm going to mark this as "not yet" in blackboard mostly as a reminder to myself that I need to review the ERD yet.
@pawaitemadisoncollege checkpoint #2 ready for review!
Equals method implemented via Lombok - will clean up setters and getters from workspace tomorrow, got a bit distracted with AWS today :)