search

potatolain / TravelPortals

A portal system for Bukkit for Minecraft
BSD 2-Clause "Simplified" License
3 stars 2 forks source link

Added ability to use as much door types as you want (for 1.8 doors), also ChatColors #13

Closed Phoenix616 closed 9 years ago

Phoenix616 commented 9 years ago

Made the config option for the door types a list rather then the two single options. This is needed to provide a simple support for the new 1.8 door types.

Also I replaced every color definition via § with the proper ChatColor as it somehow used a wrong file encoding... don't ask.

potatolain commented 9 years ago

Hey, I had some comments on the pull request - a few minor things that I'd like to see cleaned up. (I know I don't have any coding standards outlined or anything; sorry to be picky).

That said, this is pretty awesome! I hadn't even thought about that issue with this plugin. Thanks for doing this, and even moreso doing the cleanup around ChatColor - that is something that's been in there since before Bukkit, and has needed some TLC.

Once we get the few things I pointed out sorted out, I'll be happy to merge this in and cut a new release.

Thanks for the PR!

Phoenix616 commented 9 years ago

I fixed the things you pointed out :)

potatolain commented 9 years ago

Good stuff; thanks for taking care of that. Assuming nothing to crazy happens in real life, I'll merge it in, try it out, and hopefully package up a new release tonight

Thanks a lot!

potatolain commented 9 years ago

Release 2.2.10 is out, with thanks to you. Download's available now on the site (and soon on dev.bukkit.org) if you want it:

http://cpprograms.net/files/TravelPortals.zip

I did end up making one change - I got rid of the saving of the configuration file. I've avoided using that for a while, as it completely eats all formatting and comments. That file kinda depends on having some description around the poorly-named settings. Instead, I just tell users how to update. Hope that's not too big of a bummer