potatomushclient / potato

A Graphical MUSH Client for Windows, Linux and Mac OS X -
http://www.potatomushclient.com
30 stars 3 forks source link

Null String Shown As Space #396

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Not sure if you consider this a defect or not.  It's exhibited on an 
experimental new server, AresMUSH.

Steps to reproduce:

- Connect to the alpha site at mush.aresmush.com:7206
- Wait 10-15 minutes
- Page yourself

You will see the page text offset by some number of spaces.  For instance:

      %% (to Faraday): Faraday says, "Hi"

Expected is that it would start at the beginning of the line:

%% (to Faraday): Faraday says, "Hi"

The number of blank spaces at the beginning varies.   It appears from my own 
debugging that the issue is caused by a periodic timer on the server that pings 
the client to keep the connection open.  It sends a null string:  "\0"   It 
appears that Potato is accumulating those null strings and then chucking them 
(as blank spaces) onto the beginning of whatever gets sent next to the client.

This doesn't seem to happen on other clients, but if there's something I can 
change on the server side to make this more Potato-friendly (like sending a 
different character), I'd be glad to look into it.

Original issue reported on code.google.com by lynnno...@gmail.com on 27 Jun 2014 at 1:40

GoogleCodeExporter commented 9 years ago
Another option you can use, if you've implemented telnet support, is sending a 
telnet NOP. However, since Potato has support for sending a null byte as a 
keepalive now, it should really handle the server doing the same. I'll tweak it 
to ignore null bytes and make sure they don't make it to the display.

Original comment by mike@keyboardzombie.com on 12 Jul 2014 at 2:32

GoogleCodeExporter commented 9 years ago
Thanks.  FYI - I worked around this by having it send an Ansi reset character. 
Not ideal, but it'll do.  If you have a fix and want to test it, just contact 
me and I'll change it back on the alpha site.

Original comment by lynnno...@gmail.com on 14 Jul 2014 at 4:25