search

potatoqualitee / psmodulecache

This action makes caching PowerShell modules from the PowerShell Gallery easy for Linux, Windows and macOS runners.
MIT License
31 stars 12 forks source link

Action parameters of boolean type are not correctly typed #28

Closed LaurentDardenne closed 2 years ago

LaurentDardenne commented 2 years ago

Action parameters of boolean type are not correctly typed :

[bool]'false'
#True

This causes erroneous behavior.

When fixed, setting Force to $False raises an exception : image

According to the message the -Force parameter of Save-Module should still be present but no longer be used in the action parameters, because if the parameter is false the requested path is not created if it does not exist. And the documentation for this setting on MS Doc seems wrong.

potatoqualitee commented 2 years ago

thanks for finding this! would you like to submit a PR and i can do a release?

LaurentDardenne commented 2 years ago

would you like to submit a PR

Yes, that said I rewrote the Action around a module

In a few hours I will post a summary, from there you will tell me if you want to use this version or not.

potatoqualitee commented 2 years ago

awesome, thank you!

LaurentDardenne commented 2 years ago

Fixed in Vnext.