potatoqualitee / psmodulecache

This action makes caching PowerShell modules from the PowerShell Gallery easy for Linux, Windows and macOS runners.
MIT License
31 stars 12 forks source link

Fix module name case sensitive #46

Closed LaurentDardenne closed 1 year ago

LaurentDardenne commented 1 year ago

EDIT : 11/06/2023 no tag created, version v6.0 overwrites this PR

Close issue #45.

The modification reads the repository in order to find the module name to pass as a parameter to the 'Cache' action. For each module specified as a parameter, the repository is read twice. Once when constructing pathnames and second time when saving the module (Save-Module).

For the moment the cache key name uses the module names specified in the parameters. I don't know if the cache key name is case sensitive. To be checked.

As module dependencies need to be specified in the list of paths to save, for now I leave these redundant readings and will correct this later once analyze the impacts of dependency support (if possible).

The 'UbuntuRestoreCache' test workflow is configured with 'workflow_dispatch'. I plan to rearrange/delete existing workflows.

I haven't added a 'Pester' test for this case yet. It remains to be done.

LaurentDardenne commented 1 year ago

Hi, can we merge this PR?

LaurentDardenne commented 1 year ago

do not merge, the tests are incomplete. Will be replaced by a version managing dependencies.

potatoqualitee commented 1 year ago

Hey Laurent, please email me at clemaire@gmail.com anytime you need me to merge. I'm away for a little bit and that is the best way to get in touch.

Chrissy

potatoqualitee commented 1 year ago

My apologies forr the delay. i have added you as a collaborator to the repository. Do you know how to perform releases?

LaurentDardenne commented 1 year ago

Hi,

Do you know how to perform releases?

Not really.

potatoqualitee commented 1 year ago

No problem, once the PR has been merged, update the readme and specific version tests with the newest version

go here: https://github.com/potatoqualitee/psmodulecache/releases

This link can be found from the repo's first page

Click Draft a new release

image

Add a new tag with the next version image

do it for the title as well then generate release notes image

you can update the readme at any time and it'll reflect on the marketplace

if you'd prefer i can do this part, ill be less busy in a month but im trying to check my notifications more this week

LaurentDardenne commented 1 year ago

Hi, I don't have time right now. I will do this in May.

LaurentDardenne commented 1 year ago

Hi, these modifications will be overwritten with the next new version, do I still have to create a tag (without a Github Action release) for this PR?