pote / disc

Simple Disque-powered Ruby Jobs
MIT License
129 stars 6 forks source link

Test cleanup #14

Closed foca closed 9 years ago

foca commented 9 years ago

Cleans up the tests and makes them easier to read, and fixes a race condition that's preventing me from actually running the tests.

cc @pote

pote commented 9 years ago

Nice! yeah, the test suite did need a lot of improvement (and probably still does), this certainly helps.

There's a sidenote here: Ruby's timeout is dangerous and can't be trusted, this shouldn't affect our use case considering the test process is short-lived, but worth noting nonetheless. :)

Merging, thanks for the PR @foca :heart: :tada: