search

pote / gpm

Barebones dependency manager for Go.
MIT License
1.19k stars 51 forks source link

Allow comments in Godeps #4

Closed ralt closed 11 years ago

ralt commented 11 years ago

A simple check to allow comments in the Godeps file, for lines starting with #.

pote commented 11 years ago

Hey! Thanks so much for the PR!

Actually - and this is my fault, I was working on the documentation and I deleted the comments part without really noticing - comments on the Godeps file are supported already, the line that does the trick is this one, which basically uses sed to parse the file and ignore whatever is left of a #.

Thanks for the interest though! PRs are always appreciated, issues and feature requests are also great. :)

Cheers!

ralt commented 11 years ago

Ah! My bad for the PR then, feel free to close it. Glad to see enthusiastic maintainers though :-)

Cheers Le 11 sept. 2013 18:51, "Pablo Astigarraga" notifications@github.com a écrit :

Hey! Thanks so much for the PR!

Actually - and this is my fault, I was working on the documentation and I deleted the comments part without really noticing - comments on the Godeps file are supported already, the line that does the trick is this onehttps://github.com/pote/gpm/blob/master/gpm#L123-L124, which basically uses sed to parse the file and ignore whatever is left of a

.

Thanks for the interest though! PRs are always appreciated, issues and feature requests are also great. :)

Cheers!

— Reply to this email directly or view it on GitHubhttps://github.com/pote/gpm/pull/4#issuecomment-24256546 .

pote commented 11 years ago

Cool then! Closing it, thanks again!