Separate the import logic and allow overriding

pote / planet.rb

A feed aggregator implementation intended to be used with Octopress

MIT License

66 stars 19 forks source link

Separate the import logic and allow overriding #26

Closed banafederico closed 11 years ago

banafederico commented 11 years ago

Creates a PostImporter class responsible of saving the parsed posts
Modifies the executable to read the argument and override the importer

Not sure if its a good solution. Im open for comments on this one.

It's even cooler if I can tell planet what to do with the posts it gets from the feeds.

pote commented 11 years ago

The previous pull request was smaller, but in this one: did you try repackaging the gem and making sure it works? it has no tests, so we kind of have to try this by hand for now, and I can't release a new version of the gem unless I test it or I'll break everything.

banafederico commented 11 years ago

It's tested. But anyway, take a look and see if anything comes up on a Mac, don't think so, but you never know.

banafederico commented 11 years ago

I'll send some tests along in a future PR.