search

poteto / ember-changeset-validations

Validations for ember-changeset
http://bit.ly/ember-changeset-demo
Other
220 stars 98 forks source link

fix(presence on): allow for nested keys to be used in `validatePresence` -> `on` #305

Closed velrest closed 2 years ago

velrest commented 3 years ago

Changes proposed in this pull request

Support the usage of ember object keys like object.a in validatePresence({on: "object.a"}).

velrest commented 3 years ago

This maybe needs a feature flag or something like that to not break use cases of people actually having a ["my.dotted.property.name"] property.

velrest commented 3 years ago

This maybe needs a feature flag or something like that to not break use cases of people actually having a ["my.dotted.property.name"] property.

@snewcomer What do you think of this? Is this required or just leave it as a breaking change?