search

poteto / ember-changeset-validations

Validations for ember-changeset
http://bit.ly/ember-changeset-demo
Other
220 stars 98 forks source link

Update to ember-validates v4 is breaking change #314

Open fran-worley opened 2 years ago

fran-worley commented 2 years ago

V4 of ember-validates includes a significant breaking change (dropping momentJS) for anyone who uses their date validated.

We pulled this change in without realising though a minor update to Ember-changesets-validations which didn't indicate it included a breaking change.

just a suggestion to try to flag stuff like this through a major version bump, or a change log.

thanksFor maintaining such an awesome lib, 🙏🏻

snewcomer commented 2 years ago

Hi Fran! I didn't make a fuss because I didn't see the date validator used in this project. But obviously you saw an issue! Did ember-validators as a transitive dependency in ember-changeset-validations cause your app's ember-moment to bump to to 4.0? If so, my fault! I should make a note in the changelog as you noted. Also any feedback you had with the ember-validators date validator would be great!!

https://github.com/offirgolan/ember-validators/pull/100

fran-worley commented 2 years ago

Hi Scott,

Thanks for coming back so quickly. It's our fault really for not declaring ember-validators as our own dependency given we were using their date validator directly but I thought I'd raise it incase others got caught out.

I've taken the opportunity to move our app onto dateFNS, been on the todo list for a while and now seems like the path of least resistance.

I'll confess to having given up with ember-validators date validator since the update. Even though we only ever pass it a Date or null/undefined it just seems to return a time parse error. Given We had such a basic usage I've just rolled our own using one of the comparison functions from dateFNS and that's working fine.

Thanks for all your hard work! 🤩

Sent from my iPhone

On 20 Jul 2021, at 19:18, Scott Newcomer @.***> wrote:



Hi Fran! I didn't make a fuss because I didn't see the date validator used in this project. But obviously you saw an issue! Did ember-validators as a transitive dependency in ember-changeset-validations cause your app's ember-moment to bump to to 4.0? If so, my fault! I should make a note in the changelog as you noted. Also any feedback you had with the ember-validators date validator would be great!!

offirgolan/ember-validators#100https://github.com/offirgolan/ember-validators/pull/100

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/poteto/ember-changeset-validations/issues/314#issuecomment-883598296, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AARVUJPX5HY2OXNALMYV4O3TYW4XDANCNFSM5AUOMRJA.

NOTICE: The information transmitted in this e-mail is confidential, as are any files transmitted with it, and intended solely for the use of the individual(s) to whom it is addressed. If you are not the intended recipient, please telephone or email the sender and delete this message and any attachment from your system. Any views or opinions expressed are solely those of the author, and do not necessarily represent those of SafetyToolbox Ltd. SafetyToolbox Ltd cannot guarantee that attachments are virus-free or compatible with your systems and does not accept any liability in respect of viruses or computer problems which may be experienced by the recipient.