search

poteto / ember-changeset-validations

Validations for ember-changeset
http://bit.ly/ember-changeset-demo
Other
220 stars 98 forks source link

Bump `@embroider/*` related dependencies to v1 #335

Closed SergeAstapov closed 2 years ago

SergeAstapov commented 2 years ago

Changes proposed in this pull request

This should help ecosystem to migrate to v1 of @embroider/* packages.

SergeAstapov commented 2 years ago

Seem like https://github.com/poteto/ember-changeset/pull/630 and https://github.com/offirgolan/ember-validators/pull/115 need to land and released first

josemarluedke commented 2 years ago

It seems the other PRs are merged now. Can we move this forward ?

SergeAstapov commented 2 years ago

@josemarluedke ember-validators PR is merged but not released yet

snewcomer commented 2 years ago

released!

josemarluedke commented 2 years ago

@SergeAstapov could you rebase this PR and update the versions now?

SergeAstapov commented 2 years ago

@josemarluedke thank you!

@snewcomer this is now great and is ready to be rolled out as 4.0.0-beta.3

josemarluedke commented 2 years ago

@SergeAstapov @snewcomer What is the plan for getting out of beta and into v4?

SergeAstapov commented 2 years ago

@josemarluedke IMO this fix should be released as well https://github.com/validated-changeset/validated-changeset/pull/152

Not sure we need another breaking changes here.

We may work on v2 addon format but that could be done separately.

SergeAstapov commented 2 years ago

Probably we should fix https://github.com/poteto/ember-changeset-validations/issues/336 as well

SergeAstapov commented 2 years ago

Also would like to bundle in #338