search

poteto / ember-crumbly

Declarative breadcrumb navigation for Ember apps
MIT License
167 stars 78 forks source link

83 Fix Ignoring Override on Root Routes #101

Closed mrkirchner closed 7 years ago

mrkirchner commented 7 years ago

Not sure if this is the correct fix but here is a possible solution.

Questions:

Should an index in a route override the route itself? Right now it seems to do a hybrid of index at root level but route override everywhere else.

In the bread-crumbs component accepts a block test

the path /animal/quadruped/cow/show

all levels of the path have index in the route the current fix would use route override instead of index at root levels.

mrkirchner commented 7 years ago

Anyone point me in the direction of fixing the the ember try ci stuff?

Attempting to inject an unknown injection: 'service:-document'

Not really sure but dont think it is anything i changed.