search

poteto / ember-crumbly

Declarative breadcrumb navigation for Ember apps
MIT License
168 stars 78 forks source link

Support engines routes #100 #121

Closed ascudder closed 7 years ago

ascudder commented 7 years ago

Per issue #100, currently the bread-crumbs component fails to find the route object it needs if the route comes from an engine application. By changing the getOwner() function to the routing service's getHandler() function, the component should now be able to find the route object for any

This caused some changes in how the route lookup handled index routes in the test application. I'm not sure if that will be related to the changes in pull request https://github.com/poteto/ember-crumbly/pull/113, but it got the test working for now in this branch.

I also had to upgrade Ember in order to get a version of the ember routing service that works with my changes, so unfortunately this change would break compatibility with versions of Ember earlier than 2.10.

ascudder commented 7 years ago

I found that I could accomplish this fix with fewer changes needed to the Ember version and tests, so I'm closing this PR in favor of https://github.com/poteto/ember-crumbly/pull/123