search

poteto / ember-crumbly

Declarative breadcrumb navigation for Ember apps
MIT License
167 stars 78 forks source link

Ember-copy should be a dependency #141

Closed cah-brian-gantzler closed 6 years ago

cah-brian-gantzler commented 6 years ago

When upgrading to ember-crumbly 3.0.0 I received and error stating it could not find ember-copy.

I see it is in the dev-dependencies, should it be in dependencies?

dguettler commented 6 years ago

I'll have to check on ember-copy, I recall some deprecation in the back of my head... I think you can get around the error for right now by adding ember-copy as a dependency on your main application

On Wed, Sep 12, 2018 at 4:22 PM Brian Gantzler notifications@github.com wrote:

When upgrading to ember-crumbly 3.0.0 I received and error stating it could not find ember-copy.

I see it is in the dev-dependencies, should it be in dependencies?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/poteto/ember-crumbly/issues/141, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAH_kCZWfDb11PVu6AiAVpclM2Trv9Cks5uaWzpgaJpZM4WmGZw .

dguettler commented 6 years ago

fixed by #142

cah-brian-gantzler commented 6 years ago

Thanks, I had done as you suggested prior to posting the message, in case there were any other missing dependencies. Posted this issue to hopefully help other people resolve the problem

dguettler commented 6 years ago

3.0.1 fixes the issue On Thu, Sep 13, 2018 at 9:38 AM Brian Gantzler notifications@github.com wrote:

Thanks, I had done as you suggested prior to posting the message, in case there were any other missing dependencies. Posted this issue to hopefully help other people resolve the problem

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/poteto/ember-crumbly/issues/141#issuecomment-421010112, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAH_iGcnje1FfPinFGT8hGRYCKruqUeks5ual_rgaJpZM4WmGZw .