New Release to support ember engines.

poteto / ember-crumbly

Declarative breadcrumb navigation for Ember apps

MIT License

167 stars 78 forks source link

New Release to support ember engines. #145

Open rakesh5208 opened 3 years ago

rakesh5208 commented 3 years ago

code fix has been merged to master to support ember engines, new release is required to support the ember engines. Existing release has bug, Router service is wrongly injected.

GCheung55 commented 3 years ago

@dguettler anything we can help with to get a new release and should #146 be merged before a new release?

Edit Note: Updated because the wrong issue was referenced.

rakesh5208 commented 3 years ago

@GCheung55 , there is a bug, while using the ember engines, link-to component has been extended inside the ember-engines addon, that prefix the mountPoint inside the extended component. So there is one PR #146 has been created, i think before release this bug has to fixed.

GCheung55 commented 3 years ago

@rakesh5208 Sorry, I linked to the wrong PR in my comment but corrected it.