search

poteto / ember-hypersearch

Hyperspeed real-time search with caching
MIT License
55 stars 24 forks source link

Fix *super small* typo in block form example #18

Closed mattmcmanus closed 8 years ago

mattmcmanus commented 8 years ago

I didn't even notice this until I copied the example into my editor and the syntax highlighting was all like "Wha!?"

I'm loving this addon. Thanks!

poteto commented 8 years ago

Hey thanks! I need to update ember cli before I can merge this (the jQuery issue is very annoying).

Artistan commented 8 years ago

implemented in fork/rename to hypersearcher... https://www.npmjs.com/package/ember-hypersearcher

poteto commented 8 years ago

@Artistan please stop commenting on every issue and PR.

Artistan commented 8 years ago

I commented on them because I have integrated them all into a fork. You were unresponsive to my original posts and needed to move forward.

mattmcmanus commented 8 years ago

Hey, @Artistan, I get it, I was working on my own fork as well. However, commenting on each PR about your fork feels like a hostile take over. There is no need for that.

Yellow card

Artistan commented 8 years ago

no offense intended. There was 4 months of no updates and no response to my post on one of the PRs in a couple of weeks. My intent was to inform the people who made the requests and/or find those issues. I have nothing to gain from "taking over". Cheers!

homu commented 8 years ago

:umbrella: The latest upstream changes (presumably #19) made this pull request unmergeable. Please resolve the merge conflicts.