pothosware / PothosCore

The Pothos data-flow framework
https://github.com/pothosware/PothosCore/wiki
Boost Software License 1.0
300 stars 48 forks source link

Update PothosFlow submodule. #203

Closed eduardosm closed 4 years ago

eduardosm commented 4 years ago

Fixes https://github.com/pothosware/PothosFlow/issues/196

guruofquality commented 4 years ago

Theres a little ./sync_toolkits script that I ran, and committed the result. There were several submodule updates

eduardosm commented 4 years ago

Thanks, I didn't know there was that script

gvanem commented 4 years ago

Theres a little ./sync_toolkits script that I ran, and committed the result.

I was hit by the same "error: cannot 'dynamic_cast ... on the file gui/MessageWindow/LoggerChannel.cpp. After running that script, that file remains the same. But the file flow/MessageWindow/LoggerChannel.cpp is correct for my Poco:

LoggerChannel::LoggerChannel(QObject *parent):
    QObject(parent),
    _logger(Poco::Logger::get("")),
    _oldLevel(_logger.getLevel()),
    #if POCO_VERSION < 0x010A0000
    _splitter(dynamic_cast<Poco::SplitterChannel *>(_logger.getChannel()), true)
    #else
    _splitter(_logger.getChannel().cast<Poco::SplitterChannel>())
    #endif
{

So can you help on keeping all these Repos and Sub-modules up-to-date?

guruofquality commented 4 years ago

the pothos-flow submodule should be up to date with this change, but you have to run git submodule update to get git to sync them to the checked in commits, or alternatively that bash script

gvanem commented 4 years ago

Okay. It seemed my problem was that the once PothosGui repo was renamed to PothosFlow.