search

pothosware / PothosCore

The Pothos data-flow framework
https://github.com/pothosware/PothosCore/wiki
Boost Software License 1.0
302 stars 48 forks source link

HostInfo: added field to list available SIMD architectures on host device #207

Closed ncorgan closed 4 years ago

ncorgan commented 4 years ago
guruofquality commented 4 years ago

Can https://github.com/p12tic/libsimdpp be a git submodule?

ncorgan commented 4 years ago

Sure, I just wasn’t sure if it was worth it for one file, especially since that’s not the library in my SIMD proposal. Simple to do though.

On Jun 28, 2020, at 16:53, Josh Blum notifications@github.com wrote:

 Can https://github.com/p12tic/libsimdpp be a git submodule?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

guruofquality commented 4 years ago

Sure, I just wasn’t sure if it was worth it for one file, especially since that’s not the library in my SIMD proposal. Simple to do though.

Its a few files in a directory, easier to keep up to date if its a submodule. It might help with packaging to not include the sources of other projects when possible.

I would tag the repo before adding something like this

Minus the one API header call, it could be implemented as a runtime loaded module, if for some reason that was useful.

ncorgan commented 4 years ago

Sounds good. I'll start a SIMD branch with this stuff in place. My thoughts are that this branch would have:

PothosBlocks and PothosComms could have next-esque branches with the implementations I've done, and we'll have it call into the new CMake stuff as it develops. And it all comes together for the tag?

Does this work?

ncorgan commented 4 years ago

Closing. Testing a simpler solution without a full additional submodule, instead adding a file to Pothos's CMake install files.