CompilerSupport: better match library compile flags

pothosware / PothosCore

The Pothos data-flow framework

https://github.com/pothosware/PothosCore/wiki

Boost Software License 1.0

302 stars 48 forks source link

CompilerSupport: better match library compile flags #232

Closed ncorgan closed 3 years ago

ncorgan commented 3 years ago

Add flags to match C++ standard
Don't hardcode libc++ for Clang support
Closes https://github.com/pothosware/PothosCore/issues/233

guruofquality commented 3 years ago

CI seems confused. maybe its time for dist: focal

guruofquality commented 3 years ago

Clang and GCC support are identical except the executable. I think we aught to ship the compiler executable into the build just like with MSVC

ncorgan commented 3 years ago

Marking as blocked by https://github.com/pothosware/PothosCore/pull/237, as this will include the /Zc:__cplusplus MSVC flag addition mentioned by @guruofquality.

ncorgan commented 3 years ago

Actually, there is one difference between the GCC and Clang support files. Clang builds will likely result in a linker error if https://github.com/pothosware/PothosCore/issues/233 is not resolved.

guruofquality commented 3 years ago

I moved the compiler simplification to another branch: c5dd9e55bc1f586abb39f707c404c58e6729fce1 so it wont be in the cmake update commit. This pull needs a rebase after merging all that

ncorgan commented 3 years ago

Rebased and pushed