Establish minimum version when liquid-dsp exit() calls removed

pothosware / PothosLiquidDSP

Pothos toolkit for liquid DSP processing cores

https://github.com/pothosware/PothosLiquidDSP/wiki

Boost Software License 1.0

8 stars 7 forks source link

Establish minimum version when liquid-dsp exit() calls removed #11

Open ncorgan opened 4 years ago

ncorgan commented 4 years ago

Currently, liquid-dsp calls exit() when certain input validations fail, and PothosLiquidDSP can trigger these, as it does not perform its own input validation. When this bug is fixed, the next PothosLiquidDSP version should establish a minimum version to prevent running into this.

Relevant issue here: https://github.com/jgaeddert/liquid-dsp/issues/134

ncorgan commented 3 years ago

https://github.com/pothosware/PothosLiquidDSP/commit/99bdc92115110bbec1460583b5a8565bd747e579

This allows compilation with LiquidDSP versions before and after the exit() fix, but the auto-generated blocks don't do anything with the return code. This can probably be done by tweaking the mako templates, but the issue still stands.