Closed szpajder closed 5 years ago
I made a suggestion about the serial parsing, but otherwise seems great.
Just FYI I have removed that "device_id" stuff from other drivers entirely and no one has complained. :-) The way I see it "device_id" is really an internal handle that shouldnt really make it out of the API. I think its a hold over from osmotrx implementations -- which of course always had this criticism about consistent enumeration of devices. But anyway, your call.
I made a suggestion about the serial parsing, but otherwise seems great.
Hmm, so what/where is the suggestion about the serial parsing? :)
Just FYI I have removed that "device_id" stuff from other drivers entirely and no one has complained. :-) The way I see it "device_id" is really an internal handle that shouldnt really make it out of the API.
Given that libairspyhf API allows accessing devices directly by their serial number, it's probably pointless to have device_id even for internal purposes, no?
Should I remove this thing altogether?
Hmm, so what/where is the suggestion about the serial parsing? :)
I was using githubs review thing and I didnt click submit, sorry
Should I remove this thing altogether?
Ok sure :-)
airspyhf_open_sn()
. This avoids opening all connected devices in sequence and then closing others than the one requested.Tested with two devices.