pothosware / SoapyAirspyHF

SoapySDR plugin to support the Airspy HF+
https://github.com/pothosware/SoapyAirspyHF/wiki
MIT License
24 stars 17 forks source link

Use cmake version compare to determine HASGAINS #25

Closed willcode closed 1 year ago

willcode commented 1 year ago

Fixes #24

willcode commented 1 year ago

@guruofquality @ncorgan Any comments on this one?

guruofquality commented 1 year ago

@guruofquality @ncorgan Any comments on this one?

my worry is that many time package config files arent present and PC_LIBAIRSPYHF_VERSION wont be set.

I think letting cmake check for airspyhf_set_hf_att with https://cmake.org/cmake/help/latest/module/CheckFunctionExists.html with check_function_exists to set HASGAINS may be more robust

willcode commented 1 year ago

@guruofquality changed to use check_function_exists.

guruofquality commented 1 year ago

nice thanks