search

pothosware / SoapyPlutoSDR

Soapy SDR plugin for PlutoSDR
https://github.com/pothosware/SoapyPlutoSDR/wiki
GNU Lesser General Public License v2.1
53 stars 22 forks source link

Add uninstall target #39

Closed willcode closed 3 years ago

willcode commented 3 years ago

Signed-off-by: Jeff Long willcode4@gmail.com

zuckschwerdt commented 3 years ago

Where does install_manifest.txt come from? And shouldn't that only ever contain libPlutoSDRSupport.so / librtlsdrSupport.so (pothosware/SoapyRTLSDR#55)?

edit: nevermind, I now noticed it's just cmake magic ;)

willcode commented 3 years ago

cmake places install_manifest.txt in the build directory. The uninstall target is only useful when the build directory is still around. (Just saw your updated comment ...)

This is a generic way of doing uninstall. Possibly overkill for a single shared object, but it's copied from SoapySDR. The purpose of adding this target is so that PyBOMBS will work better for the remove and update targets.

zuckschwerdt commented 3 years ago

for quick reference, it's mostly verbatim the AddUninstallTarget recipe from the cmake wiki.

guruofquality commented 3 years ago

kind of wished cmake just included this as a standard macro, this is an old issue with cmake and I guess Makefile generation