pothosware / SoapyPlutoSDR

Soapy SDR plugin for PlutoSDR
https://github.com/pothosware/SoapyPlutoSDR/wiki
GNU Lesser General Public License v2.1
53 stars 22 forks source link

Fix driver key to known string #4

Closed zuckschwerdt closed 5 years ago

zuckschwerdt commented 5 years ago

Sets getDriverKey() to "PlutoSDR", sets getHardwareKey() to "ADALM-PLUTO", and returns "library_version" and "backend_version" with getHardwareInfo()

zuckschwerdt commented 5 years ago

Changes the Identification API's getDriverKey() and getHardwareKey() to return known fixed values.

This is in line with how other drivers report the keys and enables reliable driver/device identification in applications.

S.a.

https://github.com/pothosware/SoapyPlutoSDR/blob/master/PlutoSDR_Settings.cpp#L64 https://github.com/pothosware/SoapyRTLSDR/blob/master/Settings.cpp#L134 https://github.com/pothosware/SoapyAirspy/blob/master/Settings.cpp#L111 https://github.com/pothosware/SoapySDRPlay/blob/master/Settings.cpp#L131 https://github.com/pothosware/SoapyHackRF/blob/master/HackRF_Settings.cpp#L97

guruofquality commented 5 years ago

Great idea