search

pothosware / SoapyRTLSDR

SoapySDR RTL-SDR Support Module
https://github.com/pothosware/SoapyRTLSDR/wiki
MIT License
124 stars 29 forks source link

Stop advertising full-duplex capabilities #39

Closed Jeija closed 5 years ago

Jeija commented 5 years ago

SoapySDR currently advertises the RTL-SDR's RX channel as being full-duplex:

$ SoapySDRUtil --probe

...

----------------------------------------------------
-- Device identification
----------------------------------------------------
  driver=RTLSDR
  hardware=R820T

...

----------------------------------------------------
-- RX Channel 0
----------------------------------------------------
  Full-duplex: YES

...

This is obviously nonsense; I assume it only does this because SoapyRTLSDR doesn't override the default (true, full-duplex).

This very simple PR makes SoapyRTLSDR override getFullDuplex to always return false (half-duplex, i.e. no only RX and no TX capabilities).

jazzkutya commented 5 years ago

sdrplay also shows Full-duplex: YES. I think if we want to solve this we should do this in the parent method in SoapySDR. Just change the default to false or query the device to see if it has any TX channels.?

guruofquality commented 5 years ago

sdrplay also shows Full-duplex: YES. I think if we want to solve this we should do this in the parent method in SoapySDR. Just change the default to false or query the device to see if it has any TX channels.?

That seems like a pretty good idea

guruofquality commented 5 years ago

@jazzkutya https://github.com/pothosware/SoapySDR/commit/fe8dfd1879a8512aa305045ef1e6657a5a33f3b9

I appreciate the PR anyway, it doesnt hurt to be explicit about it.

Jeija commented 5 years ago

That was quick, thanks for fixing this problem :+1: