search

pothosware / SoapyRTLSDR

SoapySDR RTL-SDR Support Module
https://github.com/pothosware/SoapyRTLSDR/wiki
MIT License
124 stars 29 forks source link

compile test on msvc #4

Closed guruofquality closed 8 years ago

guruofquality commented 8 years ago

@cjcliffe One issue came up for me when building on MSVC. It didn't have a template overload for using isnan on an integer. Many of the args parsing calls use stoi, which through throw invalid_argument if the input is bad. Here are the changes, it hasnt broken anything for me, just running it by you:

cjcliffe commented 8 years ago

:+1: No complaints here; I haven't really used std::stoi and std::isnan before -- I just happened upon those while looking up simpler C++ replacements to some C stuff I was using. Also makes sense to use the single char for checking IF number since it's fixed at length 6.

Haven't had a chance to get SoapySDR running on my windows box yet; I will likely do that this weekend as I want to get some CubicSDR Soapy supported test builds out.

guruofquality commented 8 years ago