search

pothosware / SoapyRemote

Use any Soapy SDR remotely
https://github.com/pothosware/SoapyRemote/wiki
Boost Software License 1.0
122 stars 22 forks source link

SoapyRPCSocket::close never set _lastErrorMsg #43

Closed hhrhhr closed 6 years ago

hhrhhr commented 6 years ago

if SoapyRPCSocket::close() fail, then this->lastErrorMsg() return an empty string.

https://github.com/pothosware/SoapyRemote/blob/f2e51b309016324fb4f2399b9333046b0884c396/common/SoapyRPCSocket.cpp#L91

how about SOCKET_ERRNO?

        SoapySDR::logf(SOAPY_SDR_ERROR, "SoapyRPCSocket::~SoapyRPCSocket: %d", SOCKET_ERRNO);
guruofquality commented 6 years ago

good catch https://github.com/pothosware/SoapyRemote/commit/8c23b1c2fd34fc7f20e42391ff4a50584d3f1628