search

pothosware / SoapySDR

Vendor and platform neutral SDR support library.
https://github.com/pothosware/SoapySDR/wiki
Boost Software License 1.0
1.12k stars 179 forks source link

Treat MinGW CMake installation paths as Unix instead of MSYS #414

Closed antoniovazquezblanco closed 5 months ago

antoniovazquezblanco commented 1 year ago

Based on @Biswa96 review on https://github.com/pothosware/SoapySDR/pull/413, a better fix is proposed.

Sorry about the double PR! :)

antoniovazquezblanco commented 9 months ago

Ping :)

antoniovazquezblanco commented 6 months ago

Ping @ncorgan :)

guruofquality commented 5 months ago

seems almost like WIN32 doing set(CMAKE_LIB_DEST cmake) is just the odd man out and maybe should go away. I dont know if this is still the default search path thing for a visual studio install. Or maybe they should all just be set(CMAKE_LIB_DEST ${CMAKE_INSTALL_DATADIR}/cmake/${PROJECT_NAME})

But for now in the spirit of just fixing this for MINGW, should this have been UNIX OR MSYS OR MINGW?

antoniovazquezblanco commented 5 months ago

@Biswa96, what do you think about @guruofquality suggestion?

Thanks

Biswa96 commented 5 months ago

But for now in the spirit of just fixing this for MINGW, should this have been UNIX OR MSYS OR MINGW?

I do not know if this project supports msys or cygwin environment. At least, the above suggestion would not hurt mingw. So, it's ok I guess.

antoniovazquezblanco commented 5 months ago

Done

antoniovazquezblanco commented 5 months ago

Thank you very much!