search

pothosware / SoapySDRPlay3

Soapy SDR plugin for SDRPlay APIv3
https://github.com/pothosware/SoapySDRPlay3/wiki
MIT License
98 stars 15 forks source link

Rename gain controls 'IF' and 'RF' and keep the old 'IFGR' and 'RFGR' for backward compatibility without listing them #10

Open fventuri opened 4 years ago

fventuri commented 4 years ago

As discussed with @SDRplay and @vsonnier, we should rename the gain controls to 'IF' and 'RF', and keep the old gain reduction 'IFGR' and 'RFGR' for backward compatibility without listing them explicitly in 'listGains()'.

This change is now in the 'new-gain-controls' branch.

dlaw commented 3 years ago

Some references:

The original SoapySDRPlay2 issue and discussion (December 2018) https://github.com/pothosware/SoapySDRPlay2/issues/44

My previous PR to fix this in the v2 driver (November 2019) https://github.com/pothosware/SoapySDRPlay2/pull/61

A discussion about the best path forward (May 2020) https://github.com/cjcliffe/CubicSDR/issues/825

A branch of SoapySDRPlay3 which implements the changes discussed in the CubicSDR issue (May 2020) https://github.com/pothosware/SoapySDRPlay3/tree/new-gain-controls

A port of my previous PR to the v3 driver, which I opened while unaware of the above (January 2021) https://github.com/pothosware/SoapySDRPlay3/pull/26

New PR reconciling my proposed changes with a rebased new-gain-controls branch (January 2021) https://github.com/pothosware/SoapySDRPlay3/pull/27

Cheers, David