search

pothosware / pothos-library

Framework library used by all Pothos projects
www.pothosware.com
4 stars 0 forks source link

feedback loop work but we have a visualzation lock-up #100

Closed guruofquality closed 8 years ago

guruofquality commented 9 years ago

Doing a simple feedback loop (lets say an adder output to input1 with preload set) works and we have unit tests for this, however, there is a strange lock-up issue when visualizing this with a plotter widget in the gui. This was not always an issue so I suspect a newly introduced bug during development...

The reason this is a pothos-library issue and not pothos-gui is that I believe this is related to a mistake in some buffer handling code. The feedback block will produce single element outputs per work cycle, however, the framework should be sticking these single outputs into a contiguous buffer chunk, and there should not be any obvious performance impact outside of the feedback block itself.

Investigate.

guruofquality commented 8 years ago

It turns out that labels were getting into the feedback loop forever -- https://github.com/pothosware/pothos/commit/02001d639a136fe664a641b25f2308ddd68ac109