search

potmat / homebridge-google-nest-sdm

A Homebridge plugin for Google Nest devices that uses the Google Smart Device Management API. Supports Cameras, Doorbells, Displays, and Thermostats. Includes support for HomeKit Secure Video.
ISC License
134 stars 15 forks source link

Fix Axios Image Request Issue #109

Closed DannyZolp closed 9 months ago

DannyZolp commented 9 months ago

Fixes https://github.com/potmat/homebridge-google-nest-sdm/issues/97

The issue had to deal with Axios trying to process the ArrayBuffer as a JSON string, which causes the 500 error to be thrown (like in issue #97). This was fixed by requesting the image as a base64 string and then processing it on the client.

potmat commented 9 months ago

Thank you so much for the PR @DannyZolp. However this PR seems to change many unrelated things, mostly related to code style (e.g. quotation, spacing, indenting, line wrapping etc.). This makes it extremely difficult for me to determine the scope of the actual functional changes.

Are you able to modify this PR or create another one that only contains functional changes? I understand you may have a desired code style or want consistency but I think that would best be handled in a different PR.

DannyZolp commented 9 months ago

No worries! It's what I get for leaving my automatic linter on 🤦