search

potocpav / python-concur

Concur UI Framework for Python
MIT License
48 stars 2 forks source link

Specify color by list #13

Closed ggrrin closed 4 years ago

ggrrin commented 4 years ago

When the color was specified by a list instead of a tuple, exception was raised. This commit allows using the list in the same way as a tuple.

potocpav commented 4 years ago

This change unnecessarily duplicates code, and doesn't fix the same issue for 3-element and 2-element tuples. It would be cleaner not to add any new cases, but instead match on both lists and tuples with this syntax:

isinstance(c, (list, tuple))
potocpav commented 4 years ago

Could you also remove the .gitignore change from this PR? If you need to hide some local artifacts, use the .git/info/exclude file instead.

potocpav commented 4 years ago

Thanks for the PR! Merging.