potomak / jquery-instagram

Instagram jQuery plugin
http://potomak.github.io/jquery-instagram/
MIT License
554 stars 143 forks source link

Change default distance using lat/long search? #40

Closed michaelgiaimo closed 11 years ago

michaelgiaimo commented 11 years ago

According to the API specs:

Default is 1000m (distance=1000), max distance is 5000.

Do we have control over it in this script? Would love to reduce it for greater accuracy. I see in line 87:

settings.search.distance != null && (params.distance = settings.search.distance);
potomak commented 11 years ago

@velcrobots you're right, you can set the distance parameter adding a distance attribute to the search object. If you want to update documentation I'd be glad to merge such pull request.

michaelgiaimo commented 11 years ago

Awesome, will do. Does this mean we can also pass the 'FOURSQUARE_V2_ID' or 'FOURSQUARE_ID'?

potomak commented 11 years ago

Well, no (see https://github.com/potomak/jquery-instagram/blob/master/jquery.instagram.js#L81-88), but you can add those search parameters and make a pull request.

ghost commented 11 years ago

Do you mind adding this to the documentation? BY this, I mean setting the distance parameter by adding a distance attribute to the search object. Thanks!

michaelgiaimo commented 11 years ago

I'd love to - I've actually never contributed to a project on GitHub though. Do I just clone it, edit the ReadMe, then commit?

On Tue, Jul 23, 2013 at 9:59 AM, JBIRD1111 notifications@github.com wrote:

Do you mind adding this to the documentation? BY this, I mean setting the distance parameter by adding a distance attribute to the search object. Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/potomak/jquery-instagram/issues/40#issuecomment-21415629 .

potomak commented 11 years ago

It's even easier:

  1. open https://github.com/potomak/jquery-instagram/blob/master/README.md
  2. click "Edit"
  3. send the pull request