search

potomak / jquery-instagram

Instagram jQuery plugin
http://potomak.github.io/jquery-instagram/
MIT License
554 stars 143 forks source link

add bower support #49

Closed grounded042 closed 10 years ago

potomak commented 10 years ago

Thanks for this PR. Please fix indentation (ignore and dependencies) and I will merge it.

Please fix also dependency as suggested by @pburtchaell

grounded042 commented 10 years ago

@potomak sorry for the wait. I believe I have fixed the indentation and I set the jQuery version number.

grounded042 commented 10 years ago

The indentation might look a little weird, but I followed the bower indentation rules: 1 tab = 2 spaces.

potomak commented 10 years ago

@grounded042 the indentation is wrong, see https://raw.github.com/grounded042/jquery-instagram/master/bower.json

grounded042 commented 10 years ago

@potomak Not sure what happened. Looked fine on my local box. I'll take a look tonight and push again. Sorry about this.

potomak commented 10 years ago

@grounded042 no worries! You're only a couple of commits away from the merge of this PR.

grounded042 commented 10 years ago

@potomak it should be good to go now

potomak commented 10 years ago

@grounded042 it looks ok except for the jquery dependency, jquery-instagram works also with jquery v. 1, what do you think to change dependency version to "jquery": ">= 1.9.0"?

grounded042 commented 10 years ago

@potomak is there documentation on Bower supporting that? I can't seem to find good documentation on that. If it does support that, I'm all for it.

pburtchaell commented 10 years ago

I have never seen * used — I have however seen latest. My suggestion would be the register test both and see which works.

If we can't find a solution, perhaps using the current version of all dependencies/last tested version would work.

Jon Carl notifications@github.com wrote:

@potomak is there documentation on Bower supporting that? I can't seem to find good documentation on that. If it does support that, I'm all for it.

— Reply to this email directly or view it on GitHub.

potomak commented 10 years ago

@grounded042 at http://bower.io/#defining-a-package

version: A semantic version number (see semver).

Reference about semver parsing package: https://github.com/isaacs/node-semver/

grounded042 commented 10 years ago

@potomak should be all good to go now.

potomak commented 10 years ago

@grounded042 perfect, squash commits and I'll merge!

pburtchaell commented 10 years ago

FYI I asked one of the core team members for Bower which is correct: "latest" or "*". Both work the same and are accepted in all versions of Bower. It is a personal preference which you use.

potomak commented 10 years ago

@pburtchaell thanks for pointing it out.

grounded042 commented 10 years ago

@potomak squash complete!

potomak commented 10 years ago

@grounded042 thanks!