search

potrudeau / homebridge-messenger

Send HomeKit messages with HomeBridge (Pushover / IFTTT / Email)
MIT License
105 stars 9 forks source link

Add support for Pushover custom sounds #41

Open svobs opened 1 year ago

svobs commented 1 year ago

Implements issue #25: Simple change which allows custom sounds to be specified for Pushover messages.

This patch:

  1. Removes the check which prevented custom sounds from being specified in the JSON config; instead, uses supplied value, unless supplied value is empty, where it defaults to "pushover".
  2. Changes the Sound element in the UI from a dropdown to a "typeahead" text field which suggests values for the default sounds as the user types.

Nothing fancy. It won't provide a list of the user's custom sounds, but it shouldn't be too hard for a user to test out the switch to guard against typos.

elvirusDE commented 1 year ago

@potrudeau Can you please merge this?

elvirusDE commented 1 year ago

Nice work! @svobs Could you include it in your fork and publish it? Better so than waiting for ever...

svobs commented 10 months ago

Nice work! @svobs Could you include it in your fork and publish it? Better so than waiting for ever...

@elvirusDE Sorry I didn't get to this sooner. I created a fork from this PR and published it.

Search for the plugin @svobs/homebridge-messenger in Homebridge.