search

potsky / laravel-localization-helpers

🎌 Artisan commands to generate and update lang files automatically
GNU General Public License v3.0
187 stars 38 forks source link

Obsolete strings never go back into main array #29

Open gwenth opened 8 years ago

gwenth commented 8 years ago

Hi !

I don't know if this is voluntary or not but if you decide to use obsolete strings that have already been translated and call a localization:missing, the command will end up with Drink a Piña colada and/or smoke Super Skunk, you have nothing to do!

IMHO, the problem is the strings still remain in obsolete array and are not moved back into the main array.

That's more a thought than an issue but I think it could be useful if you were able to do it in both ways.

Have a nice day :)

potsky commented 7 years ago

Hi @gwenth,

in fact if an obsolete string is used again, it should go the main block and not stay in the obsolete one. I need to check this behaviour.

potsky commented 7 years ago

I just have pushed a commit with a test for this behaviour and it is ok, I cannot reproduce your problem.

The test scan file1 with only Lemma1. Then it scans file2 with only Lemma2. And finally it scans file1 again.