Support translation's fallback by providing null in new value

potsky / laravel-localization-helpers

🎌 Artisan commands to generate and update lang files automatically

GNU General Public License v3.0

187 stars 38 forks source link

Support translation's fallback by providing null in new value #40

Closed adriandmitroca closed 7 years ago

adriandmitroca commented 8 years ago

This PR resolves issue #38

adriandmitroca commented 8 years ago

potsky commented 8 years ago

Hi !

I will be back in 2 weeks to take a look on your PR. It seems your PR makes all travis CI checks fail due to a Bing translator problem. So I cannot merge it without taking a look on the code.

adriandmitroca commented 8 years ago

If you would look at the build errors you will see that tests are failing because of missing client_id property for Microsoft Translator. So my PR is not a problem in this case.