friendsofphp/php-cs-fixer old version

gemal commented 7 years ago

in https://github.com/potsky/laravel-localization-helpers/blob/5.0/composer.json

you have:

            "require": {
                "friendsofphp/php-cs-fixer": "^1.11",

shouldn't that be moved to require-dev?

potsky commented 7 years ago

Hi @gemal,

nice to see you on a an other repo ;-)

This package is required to generate lang files according to your code style. So this is not a dev requirement. It is used according to the code_style option in configuration file.

But my package should be used as a dev requirement given that it is only a developer helper.

gemal commented 7 years ago

I have "potsky/laravel-localization-helpers" in "require-dev"

can you dump the version of it?

potsky commented 7 years ago

What do you mean by dumping the version of it ? If you talk about the version you need to use, it depends of course of your laravel version.

gemal commented 7 years ago

sorry meant bumping the version of friendsofphp/php-cs-fixer to the newest version

gemal commented 7 years ago

composer require --dev friendsofphp/php-cs-fixer
Using version ^2.3 for friendsofphp/php-cs-fixer
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - potsky/laravel-localization-helpers v2.5.5 requires friendsofphp/php-cs-fixer ^1.11 -> satisfiable by friendsofphp/php-cs-fixer[1.13.x-dev, v1.11, v1.11.1, v1.11.2, v1.11.3, v1.11.4, v1.11.5, v1.11.6, v1.11.7, v1.11.8, v1.12.0, v1.12.1, v1.12.2, v1.12.3, v1.12.4, v1.13.0, v1.13.1] but these conflict with your requirements or minimum-stability.
    - potsky/laravel-localization-helpers v2.5.5 requires friendsofphp/php-cs-fixer ^1.11 -> satisfiable by friendsofphp/php-cs-fixer[1.13.x-dev, v1.11, v1.11.1, v1.11.2, v1.11.3, v1.11.4, v1.11.5, v1.11.6, v1.11.7, v1.11.8, v1.12.0, v1.12.1, v1.12.2, v1.12.3, v1.12.4, v1.13.0, v1.13.1] but these conflict with your requirements or minimum-stability.
    - potsky/laravel-localization-helpers v2.5.5 requires friendsofphp/php-cs-fixer ^1.11 -> satisfiable by friendsofphp/php-cs-fixer[1.13.x-dev, v1.11, v1.11.1, v1.11.2, v1.11.3, v1.11.4, v1.11.5, v1.11.6, v1.11.7, v1.11.8, v1.12.0, v1.12.1, v1.12.2, v1.12.3, v1.12.4, v1.13.0, v1.13.1] but these conflict with your requirements or minimum-stability.
    - Installation request for potsky/laravel-localization-helpers (locked at v2.5.5, required as 2.5.*) -> satisfiable by potsky/laravel-localization-helpers[v2.5.5].

Installation failed, reverting ./composer.json to its original content.

I cant install the newest friendsofphp/php-cs-fixer into my project :(

potsky commented 7 years ago

Hi @gemal,

can you modify my composer.json requirement about friendsofphp/php-cs-fixer and set it to ^2.3 ? Does it still works ?

potsky commented 7 years ago

Let down... The way CSFixer works has changed... I need to read the doc and implement the new format.

gemal commented 7 years ago

thx

potsky / laravel-localization-helpers

friendsofphp/php-cs-fixer old version #61