Modify erasure_base::table from reference to pointer

potswa / cxx_function

Prototype for new std::function features, compatible with C++11.

MIT License

46 stars 7 forks source link

Modify erasure_base::table from reference to pointer #15

Closed graphicsMan closed 6 years ago

graphicsMan commented 6 years ago

Ran all tests, and all tests pass except for scoped_allocator (verified that this test previously fails with -O3).

potswa commented 6 years ago

Thanks! It's also failing CI on MSVC 2015 and 2017, so I'd like to check the testcase before adopting this.

You mentioned it previously failed on Clang with -O3. Was it the same with other optimization levels? What version are you using?

potswa commented 6 years ago

Ah, I see the version info on issue #14. Still need to cross-reference the version number to mainline Clang.

Mostly I do compatibility/regression testing by copy-pasting into online compilers like Wandbox. And I might also upgrade my home C++ environment for the first time in a couple years. So this might take a few days.

potswa commented 6 years ago

Failing on -O3 is exactly what this dancing around alias analysis is supposed to prevent.

potswa commented 6 years ago

Merged.