search

potswa / cxx_function

Prototype for new std::function features, compatible with C++11.
MIT License
46 stars 7 forks source link

`[[deprecated]]` usage disabled for C++11 #21

Closed mpusz closed 4 years ago

mpusz commented 4 years ago

[[deprecated]] attribute was introduced in C++14. This library claims to be compatible with C++11. This is why it was replaced with __attribute__ usage.

potswa commented 4 years ago

Thanks!

Unfortunately I can’t accept pull requests right now as I’m outside my country without my laptop.

Hopefully in a month or two.

Sent from my iPhone

On 7 Apr 2020, at 02:08, Mateusz Pusz notifications@github.com wrote:

 [[deprecated]] attribute was introduced in C++14. This library claims to be compatible with C++11. This is why it was replaced with attribute usage.

You can view, comment on, or merge this pull request online at:

https://github.com/potswa/cxx_function/pull/21

Commit Summary

[[deprecated]] usage disabled for C++11 File Changes

M cxx_function.hpp (4) Patch Links:

https://github.com/potswa/cxx_function/pull/21.patch https://github.com/potswa/cxx_function/pull/21.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

potswa commented 4 years ago

Can you access the CI results? It’s failing on MSVC, so the attribute usage needs to be limited to GCC.

mpusz commented 4 years ago

It’s failing on MSVC, so the attribute usage needs to be limited to GCC.

I hope I fixed it with the second commit?

--- edited ---

Nope, it did not. Made the third commit.

mpusz commented 4 years ago

CI looks better now but still failing. Is it my issue?

potswa commented 4 years ago

Thanks! Right, CI keeps failing because MSVC doesn't support the scoped_allocator testcase. I should probably just disable it…

I made a little adjustment so that your fix applies for all platforms except MSVC.