GoogleCodeExporter
commented
9 years ago Thanks for the patch. A few comments:
1. Line 124:
+ private Timer delayedUpdate_ = new Timer(100, new ActionListener() {
Is there some event that we could use as a trigger instead of using a
hard-coded delay?
2. Line 729:
+-(void) setFrame:(NSRect)frameRect {
+ // Instead of using the passed frame, get the visible rect from java because
+ // the passed frame rect doesn't contain the clipped view part. Otherwise
+ // we'll overlay some parts of the Java UI.
+ if (cefBrowser.get()) {
+ CefRefPtr<CefRenderHandler> renderer =
+ cefBrowser->GetHost()->GetClient()->GetRenderHandler();
+
+ CefRect rect;
+ renderer->GetViewRect(cefBrowser, rect);
+ util_mac::TranslateRect(self, rect);
+ frameRect = (NSRect){{rect.x, rect.y}, {rect.width, rect.height}};
+ }
+ [super setFrame:frameRect];
+}
I think the way we're re-using CefRenderHandler for both windowed and
windowless rendering is making the code more difficult to understand. It might
be better to create a new Java interface that CefClient can implement just for
the native windowed implementation and leave CefRenderHandler just for
windowless rendering. It's not necessary to change it for this issue, but
something to think about for the future.
3. Line 745:
+-(void) addCefBrowser:(CefRefPtr<CefBrowser>)browser {
+ cefBrowser = browser;
+ // Register for the start and end events of "liveResize" to avoid
+ // Java paint updates while someone is resizing the main window (e.g. by
+ // pulling with the mouse cursor)
+ [[NSNotificationCenter defaultCenter] addObserver:self
+ selector:@selector(windowWillStartLiveResize:)
+ name:NSWindowWillStartLiveResizeNotification
+ object:[self window]];
+ [[NSNotificationCenter defaultCenter]
+ addObserver:self
+ selector:@selector(windowDidEndLiveResize:)
+ name:NSWindowDidEndLiveResizeNotification
+ object:[self window]];
+}
+
+-(void) removeCefBrowser {
+ cefBrowser = NULL;
+ [self removeFromSuperview];
+}
Should removeCefBrowser also remove the NSNotificationCenter observer?
4. Line 801:
+CefWindowHandle GetBrowserContentView(CefWindowHandle cefWindow, CefRect&
orig) {
This function should probably be called CreateBrowserContentView instead.
5. Line 852:
+ NSString *contentStr = [[NSString alloc]
initWithFormat:@"{{%d,%d},{%d,%d}",
+ contentRect.x, contentRect.y, contentRect.width, contentRect.height];
+ NSString *browserStr = [[NSString alloc]
initWithFormat:@"{{%d,%d},{%d,%d}",
+ browserRect.x, browserRect.y, browserRect.width, browserRect.height];
Can we use the NSStringFromRect function here?
6. There are a number of lines in util_mac.mm that are longer than 80
characters. Please wrap at 80 characters.Original comment by magreenb...@gmail.com on 29 Jul 2014 at 10:31
Original issue reported on code.google.com by
k...@censhare.deon 25 Jul 2014 at 9:40Attachments: