search

potteryhouse / stock_by_attribute_1.5.4

Stock by Attribute for Zen Cart 1.5.3
GNU General Public License v2.0
2 stars 5 forks source link

Bug - onselect of attribute error #2

Closed mc12345678 closed 10 years ago

mc12345678 commented 10 years ago

With just the version provided on ZC for beta test, receive an error after selecting an option related to image swpping. Trying to resolve, is sawl.

jeking928 commented 10 years ago

No sure what 'sawl' means, but I will investigate.

mc12345678 commented 10 years ago

Me neither and can not edit on current device. I thought that I had provided far much more detail as to browser used, error received, location in code that generated the error, etc...

From what I recall the onclhange event for items in the dropdown is attempting to swap images, but review of the code that was provided in ZC forum did not have that function identified. Considering the possibility that it was either a default/standard function of either Javascript or otherwise, attempted to do an internet search on the function and did not see any fruitful results. If it is in fact a function of some other plugin that is available, I couldn't readily identify it to be able to keep the functionality for the conditions expected. Seems like a smart option to have if/when the "support" is present.

In total I think a session expired before posting and somehow only what had been started made it to this site.

jeking928 commented 10 years ago

Confirming there is an issue with attribute images. Even a product with only one attribute (two option names, each with an image), the attribute images do not display.

potteryhouse commented 10 years ago

The code for the onselect is in the 'includes/functions/extra_functions/products_with_attributes' file in the function zen_draw_pull_down_menu_SBAmod()

mc12345678 commented 10 years ago

line 51 of includes\functions\extra_functions\products_with_attributes.php

potteryhouse commented 10 years ago

This is addressed in the current check-in "update3" (pull-request). Added missing sample file tpl_modules_main_product_image.php.

Note: This new feature relies on the use of an 'id="SBA_ProductImage"' tag added to the image box in tpl_modules_main_product_image.php

potteryhouse commented 10 years ago

Resolved in Update3, closing report.