potteryhouse / stock_by_attribute_1.5.4

Stock by Attribute for Zen Cart 1.5.3
GNU General Public License v2.0
2 stars 5 forks source link

Display Only attributes #32

Open mc12345678 opened 9 years ago

mc12345678 commented 9 years ago

Doesn't quite seem like attributes marked as display only are handled "properly" at least with Dynamic Dropdowns when using multiple attributes. Haven't checked/can't recall if there is any issue with them in the single attribute aspect. Will review the previous issues to see if it is was addressed and at some point test a product to see how it works using the original potteryhouse/jeking code for single attribute product.

mc12345678 commented 9 years ago

Has been discovered through operation that display only attributes are omitted when adding variants to the database except when using the All - Attributes - Combo selection.

The code has been written to support "filtering" of such attribute types, but needs to be modified to exclude display-only attributes.

mc12345678 commented 8 years ago

In the latest version of SBA at https://github.com/mc12345678/Stock_By_Attributes_Combined, Dynamic Dropdowns are disabled for product when option name types are used that are not recognized by DD. Therefore, although some "functionality" is lost, at least the product is not affected. There is added checking on the add-to-cart action to prevent adding a product's attributes that are not tracked by SBA, so straight through operation remains satisfactory, but the added onscreen features of DD are lost in those cases. This will be modified as each type of option name is addressed in the applicable DD code.

mc12345678 commented 8 years ago

Still haven't settled on omitting display-only attributes from ever being in a variant, but have modified DD to not display attributes that are marked as display only, default, and sort order of 0... This is the ZC recommended settings for an attribute list that has a sort of customer reminder to select an option. Other display only items if added to variants will still show if added using the All - Attributes - Combo selection, otherwise there are a few ways to either prevent such addition or to remove those attributes from the variant after the fact.