Closed mc12345678 closed 8 years ago
This was referenced by issue #48 because for the purposes of the title, this issue is closed. With DD now disabled, there is a check performed when adding product to the cart to see if the product variant does exist as a defined variant.
Closed.
Until commit: dab36bce81c3fc78c2c3feb2f34fbcea721b3b4a if a product tracked by SBA having more than one option name, with dynamic dropdowns inactive, and where the combination of option values was not assigned as an allowable variant, then it was possible that up to the quantity identified to the product (not an SBA tracked quantity) could be added to the cart without error.
The above commit has incorporated a checking process used elsewhere in the code, but performs the following:
What is not (yet) covered is the following: if a product has a variant of 2 or more option names and a variant of 1 or more option names, there is no "test" to validate that the SBA table supports distribution of the product (adding to the cart). In order to accomplish this tasking, there are a few aspects to consider, preferably from a reality standpoint rather than only a theoretical view.
2.a. Ie. would it be acceptable if two variants had overlapping objects to be considered a complete product?
2.b. What if there were two or more ways to combine the series of attributes to get a single product, which combination should be used when removing items from stock if less than the full stock quantity is chosen? the one that is lower in stock? the one that has a larger stock quantity? Some sort of tracking system indicating which is easier/harder to restock? Etc... How many different options should be offered to the user/customer?
Thoughts?