search

potteryhouse / stock_by_attribute_1.5.4

Stock by Attribute for Zen Cart 1.5.3
GNU General Public License v2.0
2 stars 5 forks source link

Bug - Custom ID (SKU) Display errors #6

Closed potteryhouse closed 10 years ago

potteryhouse commented 10 years ago

Need to update to fix the custom ID displayed on:

Admin: admin--customers--orders--details admin--customers--orders--invoice admin--customers--orders--packing slip

Front end: shopping cart account history info screen

Problem: The custom id is not working correctly. On the admin--customers--orders--details (and others) the custom id will show for the first product, but then the model number shows for all other products in the order.

potteryhouse commented 10 years ago

Partially resolved in the current check-in "update3" (pull Request). Still need to pages for display of combinations when a product without an SBA entry is also in the cart.

Look at all combinations, product with and without attributes, SBA entries with and without "customid" entered, other permutations.

potteryhouse commented 10 years ago

Additional corrections in the files templates/YOUR_TEMPLATE/templates/tpl_account_history_info_default.php and templates/YOUR_TEMPLATE/templates/tpl_checkout_confirmation_default.php

potteryhouse commented 10 years ago

I duplicated this issue, and found a similar error on other pages in admin, all have been corrected. Changes are checked into both 1.5.3 and 1.5.4 branches. Need to test!

jeking928 commented 10 years ago

Fixes look good. One suggestion. When viewing the order in the admin, what about adding a separator between the attribute name/value and the customID name/value. For example, my test I see:

Color: Blue Item # blue What about this: Color: Blue (Item # blue) putting the entire block in parenthesis. Just seems to visually separate them better.

potteryhouse commented 10 years ago

Thanks, the suggestion has been included in Update4