search

pouchdb-community / pouchdb-load

Load documents into CouchDB/PouchDB from a dumpfile
Apache License 2.0
120 stars 33 forks source link

Include query_params in replIdOpts #33

Closed wegewerk-mdt closed 9 years ago

wegewerk-mdt commented 9 years ago

Include query_params in replIdOpts. Without a useless Checkpointer ist created, leading to sync from seq=0 on next sync.

nolanlawson commented 9 years ago

Ooh, I totally missed this. This will need a test in order to pass (due to code coverage), but yeah, this is a good fix. Could you add a test so that the code coverage is fixed?

wegewerk-mdt commented 9 years ago

I copied the Test '/w a filter' and adapted it for this case. Code coverage ist at 100% again, but i dont understand why the test itself fails.

nolanlawson commented 9 years ago

Hmm, Travis says the error is quux never loaded, because its seq is 1. Did you try to run your tests locally?

wegewerk-mdt commented 9 years ago

Yes i did. The tests 1) and 2) also do fail. They also fail without my patch. I dont understand what you are trying to test there. Can you fix it?

nolanlawson commented 9 years ago

You're absolutely right; the build started breaking because of a change in PouchDB itself, which I could have avoided by implementing https://github.com/nolanlawson/pouchdb-load/issues/29. So I'll implement https://github.com/nolanlawson/pouchdb-load/issues/29 and then merge your PR.

nolanlawson commented 9 years ago

Merged as 56bfc4446dce293f0ac8fdc5d6fd0178c56327b3, thanks a lot!