improve the error handling

pouchdb-community / pouchdb-replication-stream

Replicate PouchDB/CouchDB databases with Node.js-style streams

Apache License 2.0

189 stars 58 forks source link

improve the error handling #55

Closed oliviertassinari closed 8 years ago

oliviertassinari commented 8 years ago

My issue

I want the load() API Promise to reject when the JSON is wrongly formatted. Right now, we have an error thown (async, can't be wrapped in a try/catch).

My solution

Upgrade the ldjson-stream dependency (renamed to ndjson: https://github.com/maxogden/ndjson/commit/0b2bcd00ed7b9a93a0efb096914fbbb02246ae37).
Add a listener for the 'error' event.

oliviertassinari commented 8 years ago

The build is now green 🍏 .

nolanlawson commented 8 years ago

Awesome pull request, love the new tests, thanks for the concise breakdown! Will merge and publish right now. :tada:

nolanlawson commented 8 years ago

Published in 1.2.8

oliviertassinari commented 8 years ago

Thanks for taking the time to review this PR 😄 .